Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SD-648] Change log level for user errors #1445

Merged
merged 1 commit into from
Feb 13, 2025
Merged

[SD-648] Change log level for user errors #1445

merged 1 commit into from
Feb 13, 2025

Conversation

waitingallday
Copy link
Member

Issue: https://digital-vic.atlassian.net/browse/SD-648

What I did

  • Changed logger to .info on user error

How to test

Checklist

For all PR's

  • I've added relevant changes to the project Readme if needed
  • I've updated the documentation site as needed
  • I have added tests to cover my changes (if not applicable, please state why in a comment)

For new UI components only

  • I have added a storybook story covering all variants
  • I have checked a11y tab in storybook passes
  • I have added cypress component tests (if the component is interactive)
  • Any events are emitted on the event bus using emitRplEvent

@waitingallday waitingallday added this to the 2.26.0 milestone Feb 12, 2025
@waitingallday waitingallday self-assigned this Feb 12, 2025
@cypress Cypress
Copy link

cypress bot commented Feb 12, 2025

ripple-framework    Run #2555

Run Properties:  status check passed Passed #2555  •  git commit 68060024f6: refactor: :recycle: change log level for user errors
Project ripple-framework
Branch Review task/sd-648-sumo-logs
Run status status check passed Passed #2555
Run duration 11m 03s
Commit git commit 68060024f6: refactor: :recycle: change log level for user errors
Committer Jason Smith
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 235
View all changes introduced in this branch ↗︎

@waitingallday waitingallday requested a review from lambry February 12, 2025 04:35
@waitingallday waitingallday merged commit de52edb into release/2.26.0 Feb 13, 2025
6 checks passed
@waitingallday waitingallday deleted the task/sd-648-sumo-logs branch February 13, 2025 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambry lambry lambry approved these changes

@dylankelly dylankelly dylankelly approved these changes

Assignees

@waitingallday waitingallday

Labels
None yet
Projects
None yet
Milestone
2.26.0
Development

Successfully merging this pull request may close these issues.
3 participants
@waitingallday @lambry @dylankelly